copy*(): refactor copyDirItems() to avoid passing null param#570
Merged
copy*(): refactor copyDirItems() to avoid passing null param#570
Conversation
JPeer264
approved these changes
Apr 19, 2018
| function copyDirItem (items, item, src, dest, opts, cb) { | ||
| const srcItem = path.join(src, item) | ||
| const destItem = path.join(dest, item) | ||
| checkPaths(srcItem, destItem, (err, resolvedDest) => { |
Collaborator
There was a problem hiding this comment.
Neat that it is in here now
Collaborator
Author
|
@RyanZim ping?! |
Collaborator
|
@manidlou Thanks for the ping; somehow this slipped through the cracks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactored
copyandcopySyncso thatstartCopycan have a consistent signature and no need to pass a null param. IDK, I figured that'd be easier to read and understand the code then!