make YAMLDecoder compliant to TopLevelDecoder to be used with Combine.decode

[marcblanchet]

would be cool to chain with Combine .decode(type: ..., decoder: YAMLDecoder()) but YAMLDecoder is not compliant with protocol TopLevelDecoder. XMLCoder does it and it is really useful

[jpsim]

Thanks for the suggestion! In the meantime, you should be able to add the conformance in your own code:

extension YAMLDecoder: TopLevelDecoder {
    public typealias Input = String

    public func decode<T>(_ type: T.Type, from: String) throws -> T where T : Decodable {
        try self.decode(type, from: from, userInfo: [:])
    }
}

[jpsim]

Started a PR tracking the work left to do here: #262

[marcblanchet]

suggested code seems halfway. If I do:

extension URLSession {
enum SessionErrorHTTP: Error {
    case statusCode(HTTPURLResponse)
  }
func dataTaskPublisher<T: Decodable>(for request: URLRequest) -> AnyPublisher<T, Error> {
    return self.dataTaskPublisher(for: request)
      .tryMap({ (data, response) -> Data in
        if let response = response as? HTTPURLResponse,
          (200..<300).contains(response.statusCode) == false {
          throw SessionErrorHTTP.statusCode(response)
        }
        return data
      })
      .decode(type: T.self, decoder: JSONDecoder())
      .eraseToAnyPublisher()
  }
}

I can replace JSONDecoder() above with XMLCoder or CSVDecoder, but not yet YAMLDecoder (even with your suggestion). Some piece is missing.

[jpsim]

With my provided code, you need to give the decoder a String instead of Data.

[marcblanchet]

thanks a bunch! will test it!