Apply .singleQuoted on representing Node.Scalar from String if Resolver.default resolves that to other than .str.#198
Merged
Conversation
Apply `.singleQuoted` on representing `Node.Scalar` from `String` if `Resolver.default` resolves that to other than `.str`. Fixes #197
…itTags()` It is more desirable behavior.
norio-nomura
commented
Jul 6, 2019
| public func represented() -> Node.Scalar { | ||
| return .init(self) | ||
| let scalar = Node.Scalar(self) | ||
| return scalar.resolvedTag.name == .str ? scalar : .init(self, Tag(.str), .singleQuoted) |
Collaborator
Author
There was a problem hiding this comment.
The performance impact can be almost ignored since resolvedTag was previously called in serializeScalar(_:) on serializing.
https://github.com/jpsim/Yams/blob/41c33b6f96/Sources/Yams/Emitter.swift#L413
jpsim
approved these changes
Jul 6, 2019
jpsim
left a comment
jpsim
left a comment
Owner
There was a problem hiding this comment.
Nice fix! Should we backport this to a 2.0.x release without the breaking changes?
Collaborator
Author
I'll branch |
norio-nomura
added a commit
that referenced
this pull request
Jul 7, 2019
Apply `.singleQuoted` on representing `Node.Scalar` from `String` if `Resolver.default` resolves that to other than `.str`.
norio-nomura
added a commit
that referenced
this pull request
Jul 7, 2019
…` from `String` if `Resolver.default` resolves that to other than `.str`.
ryohey
added a commit
to yonaskolb/XcodeGen
that referenced
this pull request
Jul 15, 2021
Some values are now added quotes due to Yams 3.0.0 changes in jpsim/Yams#198
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #197