Skip to content

fix(regl-renderer): added handling of element resize events #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
z3dev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(regl-renderer): added handling of element resize events #1393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions packages/utils/regl-renderer/demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<title>Demo Application</title>
<style>
#jscad{
width: 15cm;
width: 100%;
height: 15cm;
margin: 0;
outline: 1px solid black;
Expand Down Expand Up @@ -69,8 +69,11 @@

const containerElement = document.getElementById("jscad")

const width = containerElement.clientWidth
const height = containerElement.clientHeight
const pixelRatio = window.devicePixelRatio || 1
const bounds = containerElement.getBoundingClientRect()

const width = (bounds.right - bounds.left) * pixelRatio
const height = (bounds.bottom - bounds.top) * pixelRatio

const state = {}

Expand Down Expand Up @@ -133,6 +136,27 @@
// the heart of rendering, as themes, controls, etc change
let updateView = true

const doResize = () => {
const pixelRatio = window.devicePixelRatio || 1
const bounds = containerElement.getBoundingClientRect()

const width = (bounds.right - bounds.left) * pixelRatio
const height = (bounds.bottom - bounds.top) * pixelRatio

const prevWidth = containerElement.width
const prevHeight = containerElement.height

if (prevWidth !== width || prevHeight !== height) {
containerElement.width = width
containerElement.height = height

perspectiveCamera.setProjection(state.camera, state.camera, { width, height })
perspectiveCamera.update(state.camera, state.camera)
}
}

window.addEventListener('resize', (evt) => { updateView = true })

const doRotatePanZoom = () => {

if (rotateDelta[0] || rotateDelta[1]) {
Expand Down Expand Up @@ -170,6 +194,7 @@
state.camera.position = updates.camera.position
perspectiveCamera.update(state.camera)

doResize()
renderer(renderOptions)
}
window.requestAnimationFrame(updateAndRender)
Expand Down
⚡