Open
Conversation
Reduce allocations in the hot path by pooling: - Result object (reused between calls) - vertexIsBack array (pre-allocated, grows as needed) - frontvertices/backvertices arrays (pre-allocated) Also internalizes the vertices.length < 3 guard into removeConsecutiveDuplicates rather than requiring callers to check before calling. Benchmark results show 63-66% speedup for sphere/torus unions: - union sphere(16): 12.1ms → 4.5ms - union sphere(32): 96.1ms → 33.2ms - union torus(16): 61.9ms → 21.2ms Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Measures performance of the hot-path splitPolygonByPlane function across coplanar, front-only, back-only, and spanning split cases. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Member
|
@jbroll these are fine but you’ll have to prove there’s a performance benefit. Please run the performance suite, at least for the booleans. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Thank you for your help in advance, much appreciated !