Skip to content

Prefer const over let#38

Merged
pofider merged 1 commit intojsreport:masterfrom
LinusU:prefer-const
Nov 25, 2018
Merged

Prefer const over let#38
pofider merged 1 commit intojsreport:masterfrom
LinusU:prefer-const

Conversation

@LinusU
Copy link
Copy Markdown
Contributor

@LinusU LinusU commented Oct 10, 2018

In order to comply with this new standard rule ☺️

standard/eslint-config-standard#133

inputs.parentModuleDirectory
]

let consoleFromSandbox
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this was done in order to not trigger no-use-before-define, but it's actually accessed a bit up which makes that point moot... I'm open to other suggestions for this ☺️

@LinusU
Copy link
Copy Markdown
Contributor Author

LinusU commented Nov 21, 2018

ping @bjrmatos, @pofider ☺️

@pofider pofider merged commit 7176d85 into jsreport:master Nov 25, 2018
@pofider
Copy link
Copy Markdown
Contributor

pofider commented Nov 25, 2018

Thank you. Merged.

@LinusU LinusU deleted the prefer-const branch November 26, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants