Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
- removed `error` from valid test expectations - removed `type` from invalid test expectations - added eslint ^10 to the devDependencies and peerDependencies - somewhat fixed compatibility issue with RuleTester - upgraded minimatch (CVE-2026-26996)
Author
|
I know that there has been a previous pr regarding minimatch upgrades being a breaking change, if this is still an issue I can remove that from this pull request. Also none of the changes were made with ai. |
Mathlete-101
force-pushed
the
eslint-10-compat
branch
from
c25a42d to
f34ec3f
Compare
patricebouillet
added a commit
to porscheofficial/porschedigital-technology-radar
that referenced
this pull request
Apr 21, 2026
eslint-plugin-jsx-a11y@6.10.2 declares peer eslint <=9 but the project runs eslint 10. Local installs needed --legacy-peer-deps; CI's npm ci strictly enforces peers and was failing the deploy with ERESOLVE. A project-level .npmrc fixes both paths without per-workflow flag drift. Revisit once jsx-a11y publishes a release with eslint@^10 in its peerDependencies (jsx-eslint/eslint-plugin-jsx-a11y#1079, #1081).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1075
removed
errorfrom valid test expectationsremoved
typefrom invalid test expectationsadded eslint ^10 to the devDependencies and peerDependencies
somewhat fixed compatibility issue with RuleTester
upgraded minimatch (CVE-2026-26996)