Add an argument to ipcluster plugin to specify the number of engines#547
Add an argument to ipcluster plugin to specify the number of engines#547clearf wants to merge 3 commits intojtriley:developfrom
Conversation
|
Does this allow you to set |
|
I wrote some similar logic: develop...cancan101:develop#diff-4774c0a25748eaab7628c5b506730127 (sorry its intermingled with a couple other changes). |
|
Yes, it allows you to set master engines to zero and set NODE_ENGINES as well. I've had problems where my master has gotten hammered by calculations and/or memory (even with This PR is a pretty simple way of accomplishing that (and the parameters are respected for ipclusterrestart as well) |
There was a problem hiding this comment.
if self.master_engines == 0 won't this branch be taken? i.e. using 0 or None to turn of the master will not work.
There was a problem hiding this comment.
Hmm... this works in testing. Let me figure this out.
Oh, actually, at this point in the execution, this is the string '0', which evaluates to true. This is bad and confusing, though, so I will change to check for "None". Thanks.
|
Also related to this PR: #538. |
…e truth of str(0)
Also addresses #538