tagpreview only modify filepath if tagfile present#1280
Open
faisal-shah wants to merge 1 commit intojunegunn:masterfrom
Open
tagpreview only modify filepath if tagfile present#1280faisal-shah wants to merge 1 commit intojunegunn:masterfrom
faisal-shah wants to merge 1 commit intojunegunn:masterfrom
Conversation
Author
|
@junegunn Would appreciate a review of this PR. It doesn't break any existing feature(s) as far I can see, and enables a useful utility of previewing tags. Let me know if you have reservations, will try to address them. |
Author
|
@junegunn Would appreciate a review of this PR. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix issue #1279
Enables tag preview using fzf-tags:
zackhsi/fzf-tags#16