Add clp support#1427
Open
jpe90 wants to merge 2 commits intojunegunn:masterfrom
Open
Conversation
junegunn
reviewed
Sep 22, 2022
junegunn
reviewed
Sep 22, 2022
Owner
junegunn
left a comment
junegunn
left a comment
There was a problem hiding this comment.
Can clap show line numbers a la bat --style=numbers? I'd like to provide a consistent experience to the users regardless of the highlighter backend. We could use clp with nl, but then the numbers aren't highlighted.
Co-authored-by: Junegunn Choi <junegunn.c@gmail.com>
Author
|
@junegunn not currently, but that sounds like a good idea to me. I'll work on it. |
Author
|
@junegunn I noticed that bat line numbers don't seem to have background highlighting when they're on a highlighted line. Just to clarify, were you referring to the grey coloring of the number line text?
|
Owner
Yes. With |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for clp as an alternative to
batfor file previewing.In this implementation,
clpis always used for file previewing if it's found. It assumes if the program is installed, the user would want to use it for file previewing, since that's its only function.Alternatively a configuration option could be used to let users opt-in to
clpmore explicitly. Let me know if you would prefer doing it that way, or taking some other approach.