feat: add route to handle static assets#749
Draft
bryanwweber wants to merge 1 commit into
Draft
Conversation
A new route /static/* is added to retrieve assets configured as static in myst.yml.
|
❌ Deploy Preview for myst-theme failed. Why did it fail? →
|
3 tasks
bryanwweber
commented
Jan 4, 2026
Comment on lines
+134
to
+136
| data.static?.forEach((asset) => { | ||
| asset.url = updateUrl(asset.url); | ||
| }); |
Author
There was a problem hiding this comment.
question: unless Zed is mistaken, this function isn't called anywhere. Is this change needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new route
/static/*is added to retrieve assets configured as static in myst.yml.See jupyter-book/mystmd#1921
TODO:
/staticprefix to differentiate. This might mean that the content server needs to have a handler to handle the mapping from path -> hashed filename rather than handling it here.