[WIP] Use requirejs vs. require#3097
Merged
takluyver merged 1 commit intojupyter:masterfrom Dec 14, 2017
Merged
Conversation
Member
Wrong issue? |
Contributor
Author
|
Yep, thanks @jasongrout 👌 |
Member
|
@gnestor is this still a WIP, or do you think it's ready to merge? |
Contributor
Author
|
@Carreau @rgbkrk Care to review before we merge? Here is the merged PR on ipython-contrib: ipython-contrib/jupyter_contrib_nbextensions#1165 |
rgbkrk
approved these changes
Dec 14, 2017
Member
rgbkrk
left a comment
rgbkrk
left a comment
There was a problem hiding this comment.
It's looking good to me, I can't see what might be missed so I think this is fit to ship.
Member
|
Thanks @rgbkrk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #155