Add cmake_format_linter adapter#117
Merged
justinchuby merged 1 commit intojustinchuby:mainfrom Jul 25, 2025
Merged
Conversation
Owner
|
Thanks! Just checking - the tool seems to be no longer maintained (2020). Is it still a good idea to use it? |
Contributor
Author
Hmm, I'm not super familiar with the CMake formatting landscape but a quick Google suggests it doesn't have a clear winner. I have found more than zero aspects in which cmake-format could use some maintenance. If you wanted to reject it for that reason, I would understand. |
Owner
|
I am ok including it in the package. I suppose it’s up to the users to decide which lint they actually want to enable. |
Owner
|
Do you plan to make additional contributions, or would it be helpful if I release a new version after merging? |
This was referenced Jul 25, 2025
Contributor
Author
This is all I had planned for now. A new version would be very helpful, thanks! |
swolchok
added a commit
to pytorch/executorch
that referenced
this pull request
Jul 25, 2025
This uses the adapter I added to lintrunner-adapters in justinchuby/lintrunner-adapters#117 . Since there hasn't been a release yet, I copied the adapter to our repo; we can get rid of it when there's an upstream release of lintrunner-adapters and we upgrade to it. ghstack-source-id: 354d2b4 ghstack-comment-id: 3120541492 Pull-Request: #12868
swolchok
added a commit
to pytorch/executorch
that referenced
this pull request
Jul 26, 2025
This uses the adapter I added to lintrunner-adapters in justinchuby/lintrunner-adapters#117 . Since there hasn't been a release yet, I copied the adapter to our repo; we can get rid of it when there's an upstream release of lintrunner-adapters and we upgrade to it. ghstack-source-id: f0f4b2e ghstack-comment-id: 3120541492 Pull-Request: #12868
swolchok
added a commit
to pytorch/executorch
that referenced
this pull request
Jul 26, 2025
This uses the adapter I added to lintrunner-adapters in justinchuby/lintrunner-adapters#117 . Since there hasn't been a release yet, I copied the adapter to our repo; we can get rid of it when there's an upstream release of lintrunner-adapters and we upgrade to it. ghstack-source-id: 2a57ed5 ghstack-comment-id: 3120541492 Pull-Request: #12868
swolchok
added a commit
to pytorch/executorch
that referenced
this pull request
Aug 11, 2025
This uses the adapter I added to lintrunner-adapters in justinchuby/lintrunner-adapters#117 . Since there hasn't been a release yet, I copied the adapter to our repo; we can get rid of it when there's an upstream release of lintrunner-adapters and we upgrade to it. ghstack-source-id: 4d8a09b ghstack-comment-id: 3120541492 Pull-Request: #12868
swolchok
added a commit
to pytorch/executorch
that referenced
this pull request
Aug 11, 2025
This uses the adapter I added to lintrunner-adapters in justinchuby/lintrunner-adapters#117, which was released in the newest lintrunner-adapters release.
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
This uses the adapter I added to lintrunner-adapters in justinchuby/lintrunner-adapters#117, which was released in the newest lintrunner-adapters release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.