Skip to content

Fix critical security issue GHSA-h755-8qp9-cq85 protobufjs Severity Critical 9.8 / 10#252

Merged
Nevon merged 3 commits intokafkajs:masterfrom
odselsevier:master
Aug 28, 2023
Merged

Fix critical security issue GHSA-h755-8qp9-cq85 protobufjs Severity Critical 9.8 / 10#252
Nevon merged 3 commits intokafkajs:masterfrom
odselsevier:master

Conversation

@odselsevier
Copy link
Copy Markdown
Contributor

@odselsevier odselsevier commented Aug 28, 2023

Fix critical security issue
GHSA-h755-8qp9-cq85
Severity Critical 9.8/ 10

protobuf.js (aka protobufjs) 6.10.0 until 6.11.4 and 7.0.0 until 7.2.4 allows Prototype Pollution, a different vulnerability than GHSA-g954-5hwp-pp24. A user-controlled protobuf message can be used by an attacker to pollute the prototype of Object.prototype by adding and overwriting its data and functions. Exploitation can involve: (1) using the function parse to parse protobuf messages on the fly, (2) loading .proto files by using load/loadSync functions, or (3) providing untrusted input to the functions ReflectionObject.setParsedOption and util.setProperty. NOTE: this CVE Record is about Object.constructor.prototype. = ...; whereas GHSA-g954-5hwp-pp24 was about Object.proto. = ...; instead.

References
https://nvd.nist.gov/vuln/detail/CVE-2023-36665
protobufjs/protobuf.js#1899
protobufjs/protobuf.js@e66379f
protobufjs/protobuf.js@protobufjs-v7.2.3...protobufjs-v7.2.4
https://github.com/protobufjs/protobuf.js/releases/tag/protobufjs-v7.2.4
https://www.code-intelligence.com/blog/cve-protobufjs-prototype-pollution-cve-2023-36665
https://github.com/protobufjs/protobuf.js/commits/release-6.11.4

@odselsevier odselsevier changed the title Fix critical security issue GHSA-h755-8qp9-cq85 Fix critical security issue GHSA-h755-8qp9-cq85 protobufjs Aug 28, 2023
@odselsevier odselsevier changed the title Fix critical security issue GHSA-h755-8qp9-cq85 protobufjs Fix critical security issue GHSA-h755-8qp9-cq85 protobufjs Severity Critical 9.8 / 10 Aug 28, 2023
@odselsevier
Copy link
Copy Markdown
Contributor Author

@catYalere @Dieken @brianphillips @tulios @Nevon can we merge this one?

@Nevon Nevon merged commit d2367bd into kafkajs:master Aug 28, 2023
@odselsevier
Copy link
Copy Markdown
Contributor Author

@Nevon could you please release 3.3.1 ?

@joeruello
Copy link
Copy Markdown

joeruello commented Nov 3, 2023

Bump, snyk ranking my PRs red is triggering me, a release would be greatly appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants