build(deps): narrow tokio's featureset; remove unused tokio-stream#731
build(deps): narrow tokio's featureset; remove unused tokio-stream#731a-kenji wants to merge 2 commits intokdheepak:mainfrom
tokio's featureset; remove unused tokio-stream#731Conversation
|
Thank you for the PR! I wanted to do the same thing as crates-tui but haven't gotten the chance to refactor the input handling yet. That seems like a nicer way to do events. But I'm happy to merge this at the moment and revisit it when I get to that. Thoughts? |
|
Oh, thanks for the link. That does seem like a clean API. I have to look further into it. Though I am not sure the feature is really needed here? At least not yet maybe? Input handling could probably be improved independently of this event handling. For example if you have separate rendering needs, like throbbers or an actual frame rate this can make sense. But this also comes at a cost. In the example a frame is unconditionally rendered at Edit: Ah, I just saw you actually use a tick to query for I personally prefer the dependencies to be used and introduced with the features that actually use them generally. |
Not all features are being used, this opts in to these features explicitly, meaning the following unused features are not available anymore: - fs - io-std - io-util - net - signal - parking_lot Alternative: Keep the `full` feature set. But I think there is value in the explicit API surface, especially for such a powerful dependency.
Remove the unused `tokio-stream` crate. It either seems to have been pulled in by accident, or it has been superseded by the `futures` crate by now.
tokio's feature setNot all features are being used, this opts in to these features
explicitly, meaning the following unused features are not available
anymore:
-- fs
-- io-std
-- io-util
-- net
-- signal
-- parking_lot
Alternative: Keep the
fullfeature set. But I think there is value inthe explicit API surface, especially for such a powerful dependency.
tokio-streamRemove the unused
tokio-streamcrate. It either seems to have beenpulled in by accident, or it has been superseded by the
futurescrate bynow.