Add Comics, Songs, Show episodes and basedOn/originalAuthor properties#40
Open
tzengyuxio wants to merge 3 commits intokepano:mainfrom
Open
Add Comics, Songs, Show episodes and basedOn/originalAuthor properties#40tzengyuxio wants to merge 3 commits intokepano:mainfrom
tzengyuxio wants to merge 3 commits intokepano:mainfrom
Conversation
…lAuthor properties Add three new content type triplets (Category + Template + Base): - Comics: modeled after Books, with author/genre/year/rating views - Songs: modeled after Albums, with artist/album/genre views - Show episodes: Category and Base for the existing Show Episode Template Add basedOn and originalAuthor properties to Book, Movie, Show, and Video Game templates to track adaptations and source material. Update types.json with basedOn (multitext) and originalAuthor (multitext).
…ies to Comics.base - Comic Template: add basedOn and originalAuthor to match other media templates - Comics.base: declare rating, topics, last in properties section (used in views)
Rename to based-on and original-author to follow the kebab-case convention used by monthly-uses in types.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
based-onandoriginal-authorproperties to Book, Movie, Show, Video Game, and Comic templates to track adaptations and source materialbased-on(multitext) andoriginal-author(multitext) intypes.jsonDetails
New categories
The vault already has Albums but not Songs, Shows but not Show episodes, and Books but not Comics. These are natural extensions of the existing content types:
Show Episode Template.md) but was missing its Category and Basebased-on / original-author
Many books, movies, shows, and games are adaptations. These two properties allow tracking the source material and its original author, e.g.:
Naming follows the kebab-case convention established by
monthly-usesintypes.json. (Note:imdbIduses camelCase, but that appears to be specific to proper noun abbreviations rather than general multi-word properties.)Notes
While working on this I noticed two minor inconsistencies in the existing vault (not changed in this PR):
Books.baseusescategories.contains(link("Books"))while most others usenote.categories.contains(...). Both work, but the convention is inconsistent.types.jsonis missing definitions for several properties already used in templates:show,episode,cast,artist,album,cover,via, among others.Test plan
based-onandoriginal-authorfields appear when using Book/Movie/Show/Video Game/Comic templates