fix: handle broken measureInWindow by thomasttvo · Pull Request #1355 · kirillzyusko/react-native-keyboard-controller

thomasttvo · 2026-03-11T19:02:32Z

📜 Description

Fixed broken measureInWindow measurements in react-native.

💡 Motivation and Context

The measureInWindow works unreliably in Fabric + formSheet Modal (facebook/react-native#56062) or on Android with edge-to-edge enabled (facebook/react-native#56056)

Upstream fixes are available, but the problem is that it will require at least RN 0.85+ to work properly. So in this PR we add internal function that is capable of measuring given view. In future this functionality can be removed, but for now this is critical to have it bundled within a package.

Fixes #1356

📢 Changelog

JS

added viewPositionInWindow to types;
added viewPositionInWindow to codegen;
added viewPositionInWindow to bindings/module;
use viewPositionInWindow instead of measureInWindow;
added viewPositionInWindow to mocks;

iOS

implement viewPositionInWindow;
make activeWindow objc available;

Android

implement viewPositionInWindow;
add uiManager and eventDispatcher to ReactContext extensions;

🤔 How Has This Been Tested?

Tested manually on iPhone 17 Pro (iOS 26.2, simulator) and Pixel 9 Pro (API 35, emulator).

📸 Screenshots (if appropriate):

Android

Fabric

Before	After
Screen.Recording.2026-03-12.at.16.34.28.mov	Screen.Recording.2026-03-12.at.16.27.10.mov

Paper

Before	After
Screen.Recording.2026-03-12.at.16.30.43.mov	Screen.Recording.2026-03-12.at.16.21.48.mov

iOS

Fabric

Before	After
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-12.at.16.38.23.mov	Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-12.at.16.25.29.mov

Paper

Before	After
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-12.at.16.29.28.mov	Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-12.at.16.18.25.mov

📝 Checklist

CI successfully passed
I added new mocks and corresponding unit-tests if library API was changed

On Fabric, measureInWindow returns modal-surface-relative coordinates instead of screen-absolute coordinates for views inside a Modal (RN bug #52450). This causes automaticOffset to compute incorrect shift values, leaving content hidden behind the keyboard. Detect the bug by comparing measureInWindow results with onLayout coordinates. When they match, estimate absolute Y by assuming the view extends to the bottom of the screen. Also preserve the pre-keyboard frame dimensions when automaticOffset is enabled to prevent iOS modal keyboard adjustment from shrinking the frame mid-animation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

github-actions · 2026-03-11T19:03:56Z

📊 Package size report

Current size	Target Size	Difference
303074 bytes	301499 bytes	1575 bytes 📈

thomasttvo · 2026-03-11T19:05:52Z

Sorry I know you've been working on this. Let me review this PR to see what's up. It's my agent creating this automatically @kirillzyusko.

…InWindow Replace the heuristic detection of broken measureInWindow with a native windowPosition method that uses UIKit/Android view APIs to get true screen-absolute coordinates. This correctly handles Fabric + Modal where measureInWindow returns surface-relative coordinates (RN bug #52450). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Pass both x and y from windowPosition (matching original measureInWindow behavior) - Add .catch() to handle view-not-found rejection gracefully Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

On Paper architecture, viewWithTag may not find the view, causing windowPosition to reject. Fall back to measureInWindow which returns correct absolute coordinates on Paper. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Fall back to onLayout values when findNodeHandle returns null instead of silently dropping the layout event - Replace deprecated keyWindow with UIWindowScene API for iOS 13+ Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Import findNodeHandle from library's utils wrapper (consistent with KeyboardAwareScrollView usage) instead of directly from react-native - Add view.superview nil check in iOS windowPosition to avoid silently resolving with CGRectZero when superview is nil Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

thomasttvo · 2026-03-12T01:16:59Z

@kirillzyusko I took a look at this and it seems like an interesting direction. I know you're working on your own solution and submitted a PR for the RN team, but do you think this approach here would be something to consider?

kirillzyusko

Overall I like the idea. I left few comments what can be improved in current implementation - in a meantime I'll test Android/iOS both architectures to check whether it works or not!

kirillzyusko · 2026-03-12T10:28:10Z

Paper/Android:

This is because:

Error: Could not find view for tag
    at promiseMethodWrapper (10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.example.reactnativekeyboardcontroller&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:2445:45)
    at anonymous (10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.example.reactnativekeyboardcontroller&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:137449:100)
    at executeDispatch (10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.example.reactnativekeyboardcontroller&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:77718:17)
    at runWithFiberInDEV (10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.example.reactnativekeyboardcontroller&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:77696:135)
    at executeDispatchesAndReleaseTopLevel (10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.example.reactnativekeyboardcontroller&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:77992:84)
    at call (native)
    at forEachAccumulated (10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.example.reactnativekeyboardcontroller&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:77861:67)
    at anonymous (10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.example.reactnativekeyboardcontroller&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:78014:29)
    at batchedUpdatesImpl (10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.example.reactnativekeyboardcontroller&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:86481:18)
    at batchedUpdates$1 (10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.example.reactnativekeyboardcontroller&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:77978:34)
    at _receiveRootNodeIDEvent (10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.example.reactnativekeyboardcontroller&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:78003:23)
    at receiveEvent (10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.example.reactnativekeyboardcontroller&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:84702:32)
    at apply (native)
    at __callFunction (10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.example.reactnativekeyboardcontroller&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:2877:38)
    at anonymous (10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.example.reactnativekeyboardcontroller&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:2633:31)
    at __guard (10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.example.reactnativekeyboardcontroller&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:2823:15)
    at callFunctionReturnFlushedQueue (10.0.2.2:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=com.example.reactnativekeyboardcontroller&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server:2632:21)

I think you wrote:

val view = mReactContext.currentActivity?.findViewById<View>(viewTag.toInt())

Which may be not correct, because Modal will live in separate Context/Activity

P. S. fixed in 404e936

kirillzyusko · 2026-03-12T15:51:18Z

I changed code a little bit, but thank you again for the contribution! ❤️

thomasttvo · 2026-03-12T15:54:46Z

I changed code a little bit, but thank you again for the contribution! ❤️

Thanks for taking it to the finish line! @kirillzyusko

kirillzyusko · 2026-03-12T15:56:36Z

My pleasure 😊

) ## 📜 Description Automatically detect top border of `KeyboardAwareScrollView`. ## 💡 Motivation and Context Continue the epic with better discovery of component location on the screen and logical continuation of #1346 In this PR I started to detect relative position of `ScrollView`, so that I better understand if caret is not visible because it obscured by other elements (header etc.) It's still not perfectly implemented and there is still a "blind"/"dead" zone where text is already hidden but scroll doesn't happen. I'll fix it in following PRs but for now I just want to bring these changes to upcoming `1.21.0` release 🤞 We also can't use `measureInWindow` because it produces incorrect measurements, so we need to use our custom implementation that has been added in #1355 Significantly improves UI for behavior described in #1341 ## 📢 Changelog    ### JS - auto detect position of `KeyboardAwareScrollView` on the screen to better understand top border of the component relative to screen; ## 🤔 How Has This Been Tested? Tested manually on iPhone 17 Pro (iOS 26.2, simulator). ## 📸 Screenshots (if appropriate): https://github.com/user-attachments/assets/43fe233f-9c83-40c9-9642-a68e2d8e8e7c ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed

## 📜 Description Fixed `IllegalViewOperationException` crash on Android. ## 💡 Motivation and Context Original code has been introduced in #1355 and further started to be used in #1352 Now if view is not found it throws an unhandled exception and crashes the app. In reality we already handle "view not found" exception, so we should just add a proper try/catch block to handle this error correctly in Kotlin code 🤞 Closes #1443 ## 📢 Changelog    ### Android - wrap `resolveView` with `catch (e: IllegalViewOperationException)`; ## 🤔 How Has This Been Tested? Tested via e2e pipeline. ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed

thomasvo and others added 8 commits March 11, 2026 13:29

fix: pass x coordinate and handle promise rejection in windowPosition

a24317a

- Pass both x and y from windowPosition (matching original measureInWindow behavior) - Add .catch() to handle view-not-found rejection gracefully Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

style: fix Kotlin lint function signature formatting

c9b85b6

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: null-tag fallback and keyWindow deprecation

45d3459

- Fall back to onLayout values when findNodeHandle returns null instead of silently dropping the layout event - Replace deprecated keyWindow with UIWindowScene API for iOS 13+ Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

style: fix TS lint errors (sort-imports, eqeqeq, ban-types)

627c8f6

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

style: fix ObjC clang-format

48cb2af

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

kirillzyusko mentioned this pull request Mar 12, 2026

keyboardVerticalOffset is unreliable as useHeaderHeight produces different measurements for different phones #1356

Closed

kirillzyusko self-assigned this Mar 12, 2026

kirillzyusko added enhancement New feature or request 🤖 android Android specific 🍎 iOS iOS specific labels Mar 12, 2026

kirillzyusko self-requested a review March 12, 2026 09:22

kirillzyusko reviewed Mar 12, 2026

View reviewed changes

kirillzyusko added 3 commits March 12, 2026 13:19

fix: Android/Modal measurements

404e936

fix: resolve PR comments

2cc759e

fix: Ts errors

2e6d10d

kirillzyusko added the KeyboardAvoidingView 🧪 Anything related to KeyboardAvoidingView component label Mar 12, 2026

kirillzyusko marked this pull request as ready for review March 12, 2026 15:24

kirillzyusko changed the title ~~fix: handle broken measureInWindow on Fabric + Modal~~ fix: handle broken measureInWindow Mar 12, 2026

kirillzyusko added 2 commits March 12, 2026 16:40

fix: CI

1316f75

chore: revert undesired changes

88c0bab

kirillzyusko approved these changes Mar 12, 2026

View reviewed changes

kirillzyusko merged commit eb2dfbb into kirillzyusko:main Mar 12, 2026
25 checks passed

kirillzyusko added the 🌎 modal Anything that involves Modal usage label Mar 12, 2026

kirillzyusko mentioned this pull request Mar 12, 2026

fix: automatically detect top border of KeyboardAwareScrollView #1352

Merged

2 tasks

kirillzyusko mentioned this pull request Apr 27, 2026

fix: resolve view crash #1444

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: handle broken measureInWindow#1355

fix: handle broken measureInWindow#1355
kirillzyusko merged 14 commits intokirillzyusko:mainfrom
thomasttvo:fix/kav-fabric-modal

thomasttvo commented Mar 11, 2026 •

edited by kirillzyusko

Loading

Uh oh!

github-actions Bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

thomasttvo commented Mar 11, 2026

Uh oh!

thomasttvo commented Mar 12, 2026

Uh oh!

kirillzyusko left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kirillzyusko commented Mar 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

kirillzyusko commented Mar 12, 2026

Uh oh!

thomasttvo commented Mar 12, 2026

Uh oh!

kirillzyusko commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

thomasttvo commented Mar 11, 2026 • edited by kirillzyusko Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📜 Description

💡 Motivation and Context

📢 Changelog

JS

iOS

Android

🤔 How Has This Been Tested?

📸 Screenshots (if appropriate):

Android

Fabric

Paper

iOS

Fabric

Paper

📝 Checklist

Uh oh!

github-actions Bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Package size report

Uh oh!

thomasttvo commented Mar 11, 2026

Uh oh!

thomasttvo commented Mar 12, 2026

Uh oh!

kirillzyusko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kirillzyusko commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kirillzyusko commented Mar 12, 2026

Uh oh!

thomasttvo commented Mar 12, 2026

Uh oh!

kirillzyusko commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thomasttvo commented Mar 11, 2026 •

edited by kirillzyusko

Loading

github-actions Bot commented Mar 11, 2026 •

edited

Loading

kirillzyusko commented Mar 12, 2026 •

edited

Loading