Skip to content

Resolves Missing Cargo.lock #1000#1011

Merged
jonathanpallant merged 2 commits intoknurling-rs:mainfrom
AstroForge-Incorporated:feature/add-workspace-cargo-lock-for-bins
Nov 7, 2025
Merged

Resolves Missing Cargo.lock #1000#1011
jonathanpallant merged 2 commits intoknurling-rs:mainfrom
AstroForge-Incorporated:feature/add-workspace-cargo-lock-for-bins

Conversation

@N-T-K
Copy link
Copy Markdown
Contributor

@N-T-K N-T-K commented Nov 6, 2025

Fix for the missing Cargo.lock that's suggested per #1000

@jonathanpallant
Copy link
Copy Markdown
Contributor

jonathanpallant commented Nov 6, 2025

lock file version 4 was found, but this version of Cargo does not understand this lock file, perhaps Cargo needs to be updated?

Our MSRV is 1.76

@N-T-K N-T-K force-pushed the feature/add-workspace-cargo-lock-for-bins branch from 7fbafd9 to e4f773d Compare November 6, 2025 19:16
@jonathanpallant
Copy link
Copy Markdown
Contributor

CI passes, and if I build packages locally the packages pick up the contents of the workspace Cargo.lock file (minus the dependencies that particular binary does not require).

I might re-jig the CHANGELOG entry, but that can be another PR.

@jonathanpallant jonathanpallant added this pull request to the merge queue Nov 7, 2025
Merged via the queue into knurling-rs:main with commit 60239d2 Nov 7, 2025
26 checks passed
@N-T-K N-T-K mentioned this pull request Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants