Skip to content

Add serde Serialize/Deserialize derives to Table and related types (2)#1036

Merged
jonathanpallant merged 3 commits intomainfrom
feature/serialized-defmt-table
Feb 5, 2026
Merged

Add serde Serialize/Deserialize derives to Table and related types (2)#1036
jonathanpallant merged 3 commits intomainfrom
feature/serialized-defmt-table

Conversation

@jonathanpallant
Copy link
Copy Markdown
Contributor

Replaces #1033 - adds CHANGELOG updates.

cc @aimir, I tried to push to your branch but Github wouldn't let me.

gal432 and others added 2 commits February 3, 2026 10:25
This enables caching the parsed defmt Table to disk, avoiding the need
to parse the full ELF file for each test process. The cached table can
be loaded in milliseconds instead of the ~6 seconds needed to parse a
large ELF.

Types modified:
- Table, TableEntry, StringEntry, Tag, Encoding, BitflagsKey (lib.rs)
- Location (elf2table/mod.rs)

The Locations type is already a BTreeMap alias which supports serde.
Copy link
Copy Markdown
Contributor

@mhatzl mhatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

unsure if the changelog should mention this PR #1036 instead of #1033 though, because 1033 was closed. which is odd to be listed in a changelog imo.
but your choice :)

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Feb 5, 2026

Deploying knurling-defmt-book with  Cloudflare Pages  Cloudflare Pages

Latest commit: aab8dfc
Status: ✅  Deploy successful!
Preview URL: https://b4521466.knurling-defmt-book.pages.dev
Branch Preview URL: https://feature-serialized-defmt-tab.knurling-defmt-book.pages.dev

View logs

@jonathanpallant jonathanpallant added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit 32dfccb Feb 5, 2026
25 of 26 checks passed
@jonathanpallant jonathanpallant deleted the feature/serialized-defmt-table branch February 5, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants