Fix qemu-run uart printing#1048
Merged
jonathanpallant merged 4 commits intomainfrom Apr 21, 2026
Merged
Conversation
Without this, qemu-run was disconnecting from the virtual UART's TCP socket when there was a pause in the data. Now we only disconnect on error. Fixes #1047
Contributor
Author
|
Tested with ferrous-systems/rust-training#334 - I now see all the output, even with a 500ms gap between strings. |
Deploying knurling-defmt-book with
|
| Latest commit: |
4f1d3f3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://25c3e168.knurling-defmt-book.pages.dev |
| Branch Preview URL: | https://fix-qemu-run-uart.knurling-defmt-book.pages.dev |
Merged
knoellle
approved these changes
Apr 20, 2026
Member
knoellle
left a comment
knoellle
left a comment
There was a problem hiding this comment.
Was able to reproduce the issue and verify the fix.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1047 - now we carry on in the event of a UART-over-TCP read timeout.