Refactor avoid-default-panic to not rely on the linker script#1050
Open
Refactor avoid-default-panic to not rely on the linker script#1050
Conversation
Member
Author
|
Damn, didn't think about the duplicate definitions. The Not sure if there is another way to achieve the same result without using either a linker script or an unstable feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#812 introduced a feature to remove the default panicking behavior from for
defmt::panicin case the user provides their own panic handler.I don't know why this was implemented by modifying the linker script instead of just
cfging out the whole function.Not using the linker script for this also improves compatibility with macOS, see #1029 (comment)
Details
defmt::paniclogs its error message, then calls_defmt_panicto do the actual panicking._defmt_panicwasn't defined anywhere but instead there was__defmt_default_panic.avoid-default-panicfeature was enabled._defmt_panicIFF the feature is not enabled