Conversation
japaric
approved these changes
Jul 30, 2020
Member
japaric
left a comment
japaric
left a comment
There was a problem hiding this comment.
Thanks; looks good to me. For now let's also reject ranges that try to view outside a 32-bit value, e.g. {:31..33}.
japaric
reviewed
Jul 30, 2020
| #[test] | ||
| fn range() { | ||
| assert!(super::parse("{:0..4}").is_ok()); | ||
| let fmt = "{:0..4}"; |
Member
There was a problem hiding this comment.
Also, could add some tests that exercise indexed parameters? "{0:0..4} {0:2..6}" (it's OK if the bitfield slices overlap). Also something with different indices: "{0:0..4} {1:8..12}".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.