Use primitive formatting for primitive references#300
Merged
bors[bot] merged 5 commits intoknurling-rs:mainfrom Dec 15, 2020
Merged
Use primitive formatting for primitive references#300bors[bot] merged 5 commits intoknurling-rs:mainfrom
bors[bot] merged 5 commits intoknurling-rs:mainfrom
Conversation
japaric
approved these changes
Dec 14, 2020
Member
japaric
left a comment
There was a problem hiding this comment.
Nice! This looks good.
This introduced change is not explicitly tested though.
(the unit test fixed in this PR is testing the derive macro change, at least it shows that the encoding is now smaller)
The CI/nightly build is broken for reasons unrelated to this this PR. We should figure out some workaround for that ...
Closes knurling-rs#163 A single recursive call in `as_native_type` is sufficient to unpack the type from the reference. Formatting functions (`fmt.i32()` etc.) are already taking a reference, so this does not need to be changed. Tests are adjusted, so that they pass. This introduced change is not explicitly tested though.
#[warn(clippy::single_match)]
#[warn(clippy:or_fun_call)]
#[warn(clippy:useless_conversion)]
#[warn(clippy:match_like_matches_macro)]
Member
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #163
A single recursive call in
as_native_typeis sufficientto unpack the type from the reference.
Formatting functions (
fmt.i32()etc.) are already takinga reference, so this does not need to be changed.
Tests are adjusted, so that they pass.
This introduced change is not explicitly tested though.
now expands into