Conversation
we don't want to compile the stuff inside firmware to RISC-V because it depends on the cortex-m crate we do want to compile the defmt crate for all no-std targets
jonas-schievink
approved these changes
Feb 3, 2021
Contributor
jonas-schievink
left a comment
jonas-schievink
left a comment
There was a problem hiding this comment.
Great! Just some minor nits
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
Member
Author
|
bors r=jonas-schievink |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
one for stuff that can be compiled on the host (root)
one for stuff that's meant to be cross-compiled to ARM (firmware folder)