Skip to content

Impl Format for all Cows#473

Merged
bors[bot] merged 1 commit intoknurling-rs:mainfrom
mattico:impl-cow
May 15, 2021
Merged

Impl Format for all Cows#473
bors[bot] merged 1 commit intoknurling-rs:mainfrom
mattico:impl-cow

Conversation

@mattico
Copy link
Copy Markdown
Contributor

@mattico mattico commented May 14, 2021

No description provided.

@mattico
Copy link
Copy Markdown
Contributor Author

mattico commented May 14, 2021

Is that failure spurious? Can't understand why it would print out of order.

@jonas-schievink
Copy link
Copy Markdown
Contributor

You're running into #452, it's hiding the actual error:

error[E0433]: failed to resolve: use of undeclared type `Cow`
  --> qemu/src/bin/alloc.rs:40:38
   |
40 |     defmt::info!("Cow<[u32]>: {=?}", Cow::Borrowed(&[1, 2, 3, 4]));
   |                                      ^^^ not found in this scope

@jonas-schievink
Copy link
Copy Markdown
Contributor

You can test this locally via cd firmware/qemu && cargo rb alloc --features alloc

Copy link
Copy Markdown
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mattico!

bors r+

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented May 15, 2021

Build succeeded:

@bors bors Bot merged commit 0da0e51 into knurling-rs:main May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants