Skip to content

macros: match unused vars if logging is disabled#497

Merged
bors[bot] merged 1 commit intomainfrom
fix-unused-vars
May 31, 2021
Merged

macros: match unused vars if logging is disabled#497
bors[bot] merged 1 commit intomainfrom
fix-unused-vars

Conversation

@Urhengulas
Copy link
Copy Markdown
Member

Fixes #494

@Urhengulas
Copy link
Copy Markdown
Member Author

Urhengulas commented May 30, 2021

I am a bit unsure how to add a test for this. Running the snapshot tests with --no-default-features would probably work, since it then would emit the unused-vars-warnings which should mismatch the snapshots, but this seems a bit over the top.

Comment thread macros/src/lib.rs Outdated
Comment thread macros/src/lib.rs Outdated
@jonas-schievink
Copy link
Copy Markdown
Contributor

bors r+

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented May 31, 2021

Build succeeded:

@bors bors Bot merged commit 4ca63c0 into main May 31, 2021
@bors bors Bot deleted the fix-unused-vars branch May 31, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

semver-breaking: "Unused variable" errors with deny(unused).

2 participants