book/duplicates.md: discriminator -> disambiguator#513
Merged
bors[bot] merged 1 commit intoknurling-rs:mainfrom Jun 20, 2021
Merged
book/duplicates.md: discriminator -> disambiguator#513bors[bot] merged 1 commit intoknurling-rs:mainfrom
bors[bot] merged 1 commit intoknurling-rs:mainfrom
Conversation
Member
|
Hello @eupn, what is your motivation for this change? |
Member
Author
|
Hi @Urhengulas, there's a discrepancy between the word (discriminator vs disambiguator) used in the code and in the book and I'm trying to rectify it here. |
Member
|
bors r+ |
Member
|
Thank you @eupn! |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading the latest version of
defmtbook, I decided to try and list ELF symbols and realized that in the book, the worddiscriminatoris used in the "Dealing with duplicates" chapter, but in reality, the code and JSON in the symbol table uses a differently named field (disambiguator) with the same meaning.This PR updates the book to keep these terms in sync.