Conversation
Urhengulas
force-pushed
the
refactor-book
branch
from
7f1c448 to
3a1b78a
Compare
* `setup`: Deduplicate setup * `setup-app`: name `cargo.toml`; add `defmt-itm` * `macros`: Language * `primitives`: Table-ize and drop `u24` (got dropped in (#521)) * `str`: Add links to doc-rs * ...
Urhengulas
force-pushed
the
refactor-book
branch
from
4493ec5 to
37d05b9
Compare
japaric
left a comment
japaric
left a comment
There was a problem hiding this comment.
I love the visual changes with the use of blockquotes and emoji. 👍
I left several inline comments but otherwise this looks good to me. Feel free to send this to bors after addressing my comments / suggestions
| When the alternate form is used for hex and binary, the `0x`/`0b` length is subtracted from the | ||
| leading zeros. This matches [`core::fmt` behavior](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=b11809759f975e266251f7968e542756). No further | ||
| customization is supported (at the moment). | ||
| ## Alternate printing |
There was a problem hiding this comment.
could you include in this section that {}, "hello" is formatted as hello but that {:#}, "hello" is formatted as "hello" and note that this matches core::fmt behavior
There was a problem hiding this comment.
I guess you mean {:?}? I am generally unsure what the ? does anyways, since we don't have separate Debug formatting.
There was a problem hiding this comment.
I'll merge it without this being resolved and will raise the question in zulip :)
|
bors r+ |
|
Build succeeded: |
2 participants
This PR aims to update the user guide of the book to the dirbaio PRs and is doing quite some refactoring on the side.
Preview: https://deploy-preview-529--admiring-dubinsky-56dff5.netlify.app