Make order of bitflags values deterministic#564
Merged
bors[bot] merged 2 commits intoknurling-rs:mainfrom Aug 25, 2021
jonas-schievink:fix-bitflags-value-order
Merged
Make order of bitflags values deterministic#564bors[bot] merged 2 commits intoknurling-rs:mainfrom jonas-schievink:fix-bitflags-value-order
bors[bot] merged 2 commits intoknurling-rs:mainfrom
jonas-schievink:fix-bitflags-value-order
Conversation
Contributor
|
Build succeeded: |
japaric
added a commit
that referenced
this pull request
Sep 29, 2021
japaric
added a commit
that referenced
this pull request
Oct 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #563
Since each bitflags value is stored in its own symbol, their order in the final executable is up to rustc/LLVM, or even the linker. This causes unreliable output that depends on toolchain details.
This PR fixes that by storing an index in the symbol for bitflags values, which indicates their order in the source code. The decoder sorts by this index to put the values back in definition order. We now exactly match the output of the
bitflagscrate.