Support referring to Self in bitflags constants#570
Merged
bors[bot] merged 1 commit intoknurling-rs:mainfrom Sep 8, 2021
jonas-schievink:selfish-bitflags
Merged
Support referring to Self in bitflags constants#570bors[bot] merged 1 commit intoknurling-rs:mainfrom jonas-schievink:selfish-bitflags
Self in bitflags constants#570bors[bot] merged 1 commit intoknurling-rs:mainfrom
jonas-schievink:selfish-bitflags
Conversation
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial bitflags support in #528 had a restriction where referring to the
Selftype in abitflagsconstant would result in a compile error.Turns out that's entirely unnecessary and I wasn't quite awake when I wrote that code. A minor modification of the generated code avoids this somewhat annoying restriction. Instead of copying the expression verbatim, we can just refer to the associated constant created by the
bitflagscrate, and extract the raw bits.