Refactor rtt [1/2]

[Urhengulas]

First half of #573:

• defmt-rtt: Move struct Channel into own module
• defmt-rtt: Make fn host_is_connected a method of Channel
• defmt-rtt: Move struct Header into own module
• defmt-rtt: Rename fn handle to fn channel + mv to mod channel

[jonas-schievink]

Looks good! Although I think I'd prefer to drop 6874e9b, since that moves a lot more than just the Header struct, and the _SEGGER_RTT static is something that IMO doesn't belong buried in a header module. (this also needs a rebase after the recent RTT fixes, but other than that LGTM)

[Urhengulas]

Looks good! Although I think I'd prefer to drop 6874e9b, since that moves a lot more than just the Header struct, and the _SEGGER_RTT static is something that IMO doesn't belong buried in a header module. (this also needs a rebase after the recent RTT fixes, but other than that LGTM)

So - I would keep the consts and statics in the lib.rs and only move out the struct Header.

[Urhengulas]

@jonas-schievink Can you please take another look?

[jonas-schievink]

What do we gain from moving Header to another file? Since it only has 4 field and no methods, it doesn't use much code

[Urhengulas]

What do we gain from moving Header to another file? Since it only has 4 field and no methods, it doesn't use much code

Actually true

[Urhengulas]

That's it?

[jonas-schievink]

bors r+

[bors]

Build succeeded:

• ci