Add xtask option to run a single snapshot test by name#585
Merged
Conversation
This is to only run a single snapshot test when checking things without running all tests again.
jonas-schievink
approved these changes
Sep 23, 2021
Contributor
jonas-schievink
left a comment
jonas-schievink
left a comment
There was a problem hiding this comment.
Implementation looks good, feel free to send to bors
| match source { | ||
| "all" => Ok(Snapshot::All), | ||
| test => { | ||
| if ALL_SNAPSHOT_TESTS.contains(&test) { |
Contributor
There was a problem hiding this comment.
This doesn't work with the conditionally-available alloc test, but that's probably not a big problem
added 2 commits
September 24, 2021 15:30
This re-adds the logic to validate a given test with the available ones.
Contributor
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to only run a single snapshot test when checking things without running all tests again.
will only run the
logsnapshot test. In case no test name is given, all tests are run as before. The test name of the positional parameter (<single>) is checked against the allowed list of snapshot tests.