Skip to content

Remove timestamps from snapshot test#591

Merged
bors[bot] merged 1 commit intoknurling-rs:mainfrom
jonas-schievink:rm-timestamp-from-snapshot-tests
Sep 27, 2021
Merged

Remove timestamps from snapshot test#591
bors[bot] merged 1 commit intoknurling-rs:mainfrom
jonas-schievink:rm-timestamp-from-snapshot-tests

Conversation

@jonas-schievink
Copy link
Copy Markdown
Contributor

This keeps the diff much cleaner when a line is added. Previously the entire rest of the file changed because of the increasing timestamps.

The timestamp functionality is still tested in timestamp.rs.

Copy link
Copy Markdown
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

bors r+

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Sep 27, 2021

Build succeeded:

@bors bors Bot merged commit e021e7d into knurling-rs:main Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants