Skip to content

defmt-print: Log if malformed frame gets skipped#610

Merged
bors[bot] merged 6 commits intomainfrom
refactor-defmt-print
Oct 21, 2021
Merged

defmt-print: Log if malformed frame gets skipped#610
bors[bot] merged 6 commits intomainfrom
refactor-defmt-print

Conversation

@Urhengulas
Copy link
Copy Markdown
Member

@Urhengulas Urhengulas commented Oct 11, 2021

Also add --verbose-flag to also show non-defmt logs.

Fixes #609

Example

❯ bat defmt-frames | cargo run -- -e hello -v
    Finished dev [unoptimized + debuginfo] target(s) in 0.02s
     Running `/home/urhengulas/Documents/github.com/knurling-rs/defmt/target/debug/defmt-print -e hello -v`
0 INFO  Lorem Ipsum is simply dummy text
└─ hello::__cortex_m_rt_main @ /home/urhengulas/Documents/github.com/knurling-rs/defmt-app/src/bin/hello.rs:8
1 INFO  of the printing and typesetting 
└─ hello::__cortex_m_rt_main @ /home/urhengulas/Documents/github.com/knurling-rs/defmt-app/src/bin/hello.rs:9
2 INFO  industry. Lorem Ipsum has been the 
└─ hello::__cortex_m_rt_main @ /home/urhengulas/Documents/github.com/knurling-rs/defmt-app/src/bin/hello.rs:10
(HOST) WARN  malformed frame skipped
└─ defmt_print @ print/src/main.rs:79
4 INFO  since the 1500s, when an unknown printer 
└─ hello::__cortex_m_rt_main @ /home/urhengulas/Documents/github.com/knurling-rs/defmt-app/src/bin/hello.rs:12
5 INFO  took a galley of type and scrambled it to 
└─ hello::__cortex_m_rt_main @ /home/urhengulas/Documents/github.com/knurling-rs/defmt-app/src/bin/hello.rs:13
6 INFO  make a type specimen book.

Comment thread print/src/main.rs
Comment thread print/src/main.rs
@Urhengulas Urhengulas requested a review from justahero October 19, 2021 15:02
Copy link
Copy Markdown

@justahero justahero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Urhengulas
Copy link
Copy Markdown
Member Author

bors r=justahero

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Oct 21, 2021

Build succeeded:

@bors bors Bot merged commit 033fbcb into main Oct 21, 2021
@bors bors Bot deleted the refactor-defmt-print branch October 21, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indicate a faulty frame is skipped

2 participants