Bugfix: decoder breaks with pipe symbol#614
Merged
Conversation
added 2 commits
October 14, 2021 16:01
This removes the detection that a given `format` in a
`Type::FormatSequence` is an `enum` which does not apply to
```rust
struct State {}
impl defmt::Format for State {
fn format(&self, f: defmt::Formatter) {
defmt::write!(f, "{=u8}|", 42)
}
}
```
The decoder wrongly analyzed this inner custom format `{=u8}|` to be an `enum`.
* expand decoder test to handle `Tag::Derived` with a `|` (pipe) symbol correctly * add output to `log` snapshot test
justahero
force-pushed
the
fix-decoder-breaks-with-pipe-symbol
branch
from
96fc0cc to
21306b3
Compare
Member
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #565 where a pipe symbol (
'|') in a format string could break the decoder.(Thanks @japaric for debugging this issue)