Add attributes for Format derive to use Debug2Format on specific fields#662
Merged
bors[bot] merged 8 commits intoknurling-rs:mainfrom Feb 22, 2022
Merged
Conversation
cddcb3e to
92a4b69
Compare
92a4b69 to
98603a8
Compare
Member
|
Looks really good! Thank you @mattico! |
Urhengulas
approved these changes
Feb 22, 2022
Member
|
Since I am not super proficient with macros I'd like @jonas-schievink to take a quick look before merging. |
Contributor
|
Great to see this, thanks! bors r+ |
Contributor
|
Build succeeded: |
mattico
commented
Feb 22, 2022
|
|
||
| if let Some(FormatOption::Debug2Format) = format_opt { | ||
| stmts.push(quote!(defmt::export::fmt(&defmt::Debug2Format(&#ident)))); | ||
| } else if let Some(FormatOption::Display2Format) = format_opt { |
Contributor
Author
There was a problem hiding this comment.
I suppose these didn't need to be if lets
Member
There was a problem hiding this comment.
True, either normal if-else or match might be better suited.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I often have structs or enums where most fields impl
Format, but a few third-party types do not. It is a pain to have to manually implFormatfor the whole type when only one field doesn't work. I added an attribute that lets you override specific fields to useDebug2FormatorDisplay2Formatlike so: