Skip to content

Fix #536 - add help for format string parsing error#735

Merged
bors[bot] merged 4 commits intomainfrom
fix-536-format-string-parser-error
Mar 10, 2023
Merged

Fix #536 - add help for format string parsing error#735
bors[bot] merged 4 commits intomainfrom
fix-536-format-string-parser-error

Conversation

@jonathanpallant
Copy link
Copy Markdown
Contributor

@jonathanpallant jonathanpallant commented Mar 8, 2023

  1. Replaces Cow<str> with an enum Error to accurately describe the parse error
  2. Uses thiserror to convert the Error enum into strings, which match the strings previously returned from the parse function
  3. Uses that enum to add help text for Error::UnknownDisplayHint.

Closes #536

Uses `thiserror` to convert the `Error` enum into strings, which match the strings previously returned from the `parse` function.
Adds help text for Error::UnknownDisplayHint.

Closes #536
Comment thread CHANGELOG.md Outdated
Comment thread macros/src/function_like/println.rs Outdated
@Urhengulas
Copy link
Copy Markdown
Member

bors r+

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Mar 10, 2023

Build succeeded:

@bors bors Bot merged commit d409209 into main Mar 10, 2023
@bors bors Bot deleted the fix-536-format-string-parser-error branch March 10, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

format string parser error should point to the docs

2 participants