Fix accidental breaking change in Format macro#954
Merged
Conversation
Veykril
force-pushed
the
veykril/push-mtmoqvylqpuw
branch
from
b5e50fb to
1e2b926
Compare
Deploying knurling-defmt-book with
|
| Latest commit: |
8459657
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ec6d1770.knurling-defmt-book.pages.dev |
| Branch Preview URL: | https://veykril-push-mtmoqvylqpuw.knurling-defmt-book.pages.dev |
skade
approved these changes
Apr 1, 2025
Veykril
force-pushed
the
veykril/push-mtmoqvylqpuw
branch
from
1e2b926 to
8459657
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/knurling-rs/defmt/pull/948/files#diff-0613bd222ac6714be0d35f8f2f1ecaa685b8fa455726083f7ed6e866f5161b2f accidentally fully qualified the
defmtpath being used, forcing the lookup to happen exclusively in the extern prelude which is a breaking changeFixes #953
We'll need to yank the 1.0.0 release after this 😬