Add textDecorationColor, textDecorationWidth, and textDecorationStyle for Text#2038
Open
rcoenen wants to merge 1 commit intokonvajs:masterfrom
Open
Add textDecorationColor, textDecorationWidth, and textDecorationStyle for Text#2038rcoenen wants to merge 1 commit intokonvajs:masterfrom
rcoenen wants to merge 1 commit intokonvajs:masterfrom
Conversation
e4bb73f to
e6ed797
Compare
… for Text Three new properties for independent control of text decoration styling, mirroring CSS text-decoration sub-properties: - textDecorationColor: decoration color independent of text fill - textDecorationWidth: override default line thickness (fontSize / 15) - textDecorationStyle: 'solid' (default), 'dashed', 'dotted', 'double', 'wavy' All apply to both underline and line-through decorations. Falls back to existing behavior when unset (fully backward compatible). Addresses konvajs#2037 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
e6ed797 to
3a80bb8
Compare
Member
|
I think we should have all under the same property as in css. To have API minimal: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three new properties for
Textnodes, mirroring CSStext-decorationsub-properties:textDecorationColorDecoration color independent of text fill.
textDecorationWidthOverride default line thickness (
fontSize / 15).textDecorationStyle'solid'(default),'dashed','dotted','double', or'wavy'.Use cases
Changes
TextConfiginterfaceAddresses #2037