Open
Conversation
Author
|
Fix for this issue |
krille-chan
reviewed
Dec 18, 2025
| required Widget Function(BuildContext context) builder, | ||
| }) => showDialog<T>( | ||
| context: context, | ||
| useSafeArea: false, |
Owner
There was a problem hiding this comment.
This does change it for all showScaffoldDialog uses. Have you checked all of them? Maybe better make this configurable, keep the default to false and only for the share screen make it true?
Author
There was a problem hiding this comment.
Ah! I'll have a dig and see what other dialogs are using it then test them.
Author
There was a problem hiding this comment.
I have checked the uses of this dialog. they are all working fine. There are several forwarding and sharing screens using it.
(image_viewer.dart, chat_list.dart, and chat.dart)
Author
There was a problem hiding this comment.
ops not sure if i should use resolved or not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
share screen previously was overlaping the navigation and notification bars
Thank you so much for your contribution to FluffyChat ❤️❤️❤️
Pull Request has been tested on: