Skip to content

feat: enable audio & video for Linux targets#2473

Open
TheSunCat wants to merge 2 commits intokrille-chan:mainfrom
TheSunCat:feat/linuxaudio
Open

feat: enable audio & video for Linux targets#2473
TheSunCat wants to merge 2 commits intokrille-chan:mainfrom
TheSunCat:feat/linuxaudio

Conversation

@TheSunCat
Copy link
Copy Markdown
Contributor

@TheSunCat TheSunCat commented Jan 10, 2026

Thank you so much for your contribution to FluffyChat ❤️❤️❤️

Pull Request has been tested on:

  • Android
  • iOS
  • Browser (Chromium based)
  • Browser (Firefox based)
  • Browser (WebKit based)
  • Desktop Linux
  • Desktop Windows
  • Desktop macOS

Description

I use FluffyChat on my Linux phone (via Flatpak), and I wanted to listen to & send voice messages. This MR makes this possible by enabling the just_audio_media_kit package and initializing it.
Additionally, I enable the video player by adding the fvp dependency (not used by default on Android and iOS, though their docs encourage doing so for performance).

Before merging

How do other platforms handle audio libs? Currently I am forcing Linux to load via JustAudioMediaKit.ensureInitialized, but (probably) this should be based on the target platform. I don't have access to any others to test on though, so I figured I'd submit this MR for review and figure it out here :)

@TheSunCat TheSunCat marked this pull request as draft January 10, 2026 00:48
@TheSunCat
Copy link
Copy Markdown
Contributor Author

I added another commit which fixes the video player on Linux (and probably Windows, but I don't have a machine to test on). Fixes #1516

@TheSunCat TheSunCat marked this pull request as ready for review February 5, 2026 19:32
@TheSunCat TheSunCat force-pushed the feat/linuxaudio branch 2 times, most recently from f186789 to 6fa06a9 Compare February 6, 2026 15:29
@TheSunCat
Copy link
Copy Markdown
Contributor Author

Fixed all the checks. Should be ready for merge, though I don't know how to edit the title of the MR to remove "WIP" 😅

@TheSunCat TheSunCat force-pushed the feat/linuxaudio branch 3 times, most recently from 1fda2bf to 1a7c56a Compare February 6, 2026 15:47
@TheSunCat
Copy link
Copy Markdown
Contributor Author

Aha, code_tests was failing 😄
just_audio_media_kit is licensed under the Unlicense which, according to this matrix (IANAL) is compatible with AGPL. Therefore I added it to licenses.yaml as permitted.

I fixed all the warnings, though I disagree with pubspec.yaml dependencies needing to be alphabetical (I would much rather put related deps together).

@krille-chan
Copy link
Copy Markdown
Owner

@TheSunCat thank you so much :-) before we merge we should check if this actually works inside of a snap and inside of a flatpak. There we might need to adjust something with the sandbox stuff

@TheSunCat
Copy link
Copy Markdown
Contributor Author

You're welcome :)

I am rewriting the FluffyChat flatpak to build from source (developing here, not ready yet), and as part of that I noticed that the fvp package adds a new requirement on libmpv.

So this definitely has to be addressed in the snap as well before merging this.

@TheSunCat TheSunCat changed the title WIP: feat: enable audio for Linux targets feat: enable audio for Linux targets Mar 29, 2026
@TheSunCat TheSunCat changed the title feat: enable audio for Linux targets feat: enable audio & video for Linux targets Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants