feat: enable audio & video for Linux targets#2473
feat: enable audio & video for Linux targets#2473TheSunCat wants to merge 2 commits intokrille-chan:mainfrom
Conversation
c391ef0 to
a01f97b
Compare
a01f97b to
c391ef0
Compare
|
I added another commit which fixes the video player on Linux (and probably Windows, but I don't have a machine to test on). Fixes #1516 |
53aa856 to
8c0b5f7
Compare
f186789 to
6fa06a9
Compare
|
Fixed all the checks. Should be ready for merge, though I don't know how to edit the title of the MR to remove "WIP" 😅 |
1fda2bf to
1a7c56a
Compare
|
Aha, I fixed all the warnings, though I disagree with |
|
@TheSunCat thank you so much :-) before we merge we should check if this actually works inside of a snap and inside of a flatpak. There we might need to adjust something with the sandbox stuff |
|
You're welcome :) I am rewriting the FluffyChat flatpak to build from source (developing here, not ready yet), and as part of that I noticed that the So this definitely has to be addressed in the snap as well before merging this. |
1a7c56a to
d43ebe5
Compare
Thank you so much for your contribution to FluffyChat ❤️❤️❤️
Pull Request has been tested on:
Description
I use FluffyChat on my Linux phone (via Flatpak), and I wanted to listen to & send voice messages. This MR makes this possible by enabling the
just_audio_media_kitpackage and initializing it.Additionally, I enable the video player by adding the fvp dependency (not used by default on Android and iOS, though their docs encourage doing so for performance).
Before merging
How do other platforms handle audio libs? Currently I am forcing Linux to load via
JustAudioMediaKit.ensureInitialized, but (probably) this should be based on the target platform. I don't have access to any others to test on though, so I figured I'd submit this MR for review and figure it out here :)