Remove ActiveSupport dependency#141
Merged
dblock merged 2 commits intokslazarev:masterfrom Jun 21, 2017
Merged
Conversation
This commit removes the dependency on the `ActiveSupport` gem by doing
the following:
- Replace `constantize` with `Object.const_get()`
- Remove the following `Object` methods:
- `blank?`
- `present?`
- Remove the following `String` methods:
- `camelcase`
- `titleize`
- `underscore`
Closes kslazarev#106
jlduran
force-pushed
the
no-activesupport
branch
from
3239583 to
c81d1d5
Compare
Repository owner
deleted a comment from
coveralls
Jun 20, 2017
dblock
requested changes
Jun 20, 2017
Collaborator
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
This is good. You still need to re-generate a .gemspec without the AS dependency.
Or maybe rewrite .gemspec by hand and remove Jeweler too?
Collaborator
Author
|
Yes, I plan on releasing the gem over the weekend if there are no issues. I'll try to remove Jeweler as well, as you propose, although I would prefer to do it in a separate commit. Thank you! |
1 similar comment
Collaborator
|
Merged, looks great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the dependency on the
ActiveSupportgem by doing the following:constantizewithObject.const_get()Objectmethods:blank?present?Stringmethods:camelcasetitleizeunderscoreCloses #106