Merged
Conversation
jlduran
reviewed
Nov 29, 2017
Collaborator
jlduran
left a comment
jlduran
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Would you mind addressing those minor issues.
| ## 0.11.3 (Next) | ||
|
|
||
| ### Features | ||
| * Your contribution here. |
Collaborator
There was a problem hiding this comment.
Please, do not remove this line.
Contributor
Author
There was a problem hiding this comment.
I will revert it as default.
|
|
||
| def hundreds(options = {}) | ||
| if @figures.hundreds.to_i.zero? | ||
| translate :hundreds, 0, options |
Collaborator
There was a problem hiding this comment.
Coveralls is complaining that this line is not getting tested.
Contributor
Author
There was a problem hiding this comment.
I will update test case to cover this line.
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support translate number to words for Vietnamese