Add pronounced option tests (for :en & :nl)#214
Open
Wessel-Boers wants to merge 1 commit intokslazarev:masterfrom
Open
Add pronounced option tests (for :en & :nl)#214Wessel-Boers wants to merge 1 commit intokslazarev:masterfrom
pronounced option tests (for :en & :nl)#214Wessel-Boers wants to merge 1 commit intokslazarev:masterfrom
Conversation
Collaborator
|
Thanks, try to implement it? I am not in love with "pronounced", maybe "spoken", or an interface that can be more common across other languages such as |
Collaborator
Oh I just saw #213 (comment)! If we already have that in English then we should absolutely do this in other languages. Try to implement this and document it for English as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the result of a conversation from issue #213 . This issue discusses the introduction of an option that would make numbers -> words as they are spoken.
For example:
However! While looking through the code, I came across an option for only the English locale that already implements this! It's the
pronouncedoption. Although not mentioned as an option in the README, it already does what we've discussed.I could not find tests for this option for the English locale. This PR adds tests that should pass. It also adds failing tests for the Dutch (:nl) locale.
I propose that the README is updated, so everyone can find about this option. And hopefully we can implement the functionality for other languages as well.