Namespaced NumbersAndWords#7
Merged
kslazarev merged 1 commit intokslazarev:developmentfrom Mar 24, 2012
Merged
Conversation
Collaborator
Author
|
Btw, you can view the diff with |
Owner
|
Wow, I didn't know about |
Owner
|
You'll right in both cases. :) |
Owner
|
Also for single line ruby block we should use '{}' , as more preferable approach, I think. We must use code space more rational. (but code line length should not be greater 90) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There're quite a few things in the global namespace, who knows what they collide with :) Namespaced everything to NumbersAndWords.
Small note: there're a couple of places where namespace were declared as
module Foo::Bar, which is actually different fromThe first case requires the namespace to have already been declared elsewhere, which would break depending in which order the files are loaded.