docs: add release guide and align chart publishing#569
Open
Asish Kumar (officialasishkumar) wants to merge 2 commits intokubefleet-dev:mainfrom
Open
docs: add release guide and align chart publishing#569Asish Kumar (officialasishkumar) wants to merge 2 commits intokubefleet-dev:mainfrom
Asish Kumar (officialasishkumar) wants to merge 2 commits intokubefleet-dev:mainfrom
Conversation
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds a maintainer-facing
RELEASE.md, links it fromCONTRIBUTING.md, and aligns the chart publishing workflow with the tagged release path so the documented behavior matches the actual release automation.Fixes #536
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
make reviewableruby -e 'require "yaml"; YAML.load_file(".github/workflows/chart.yml"); puts "chart.yml ok"'publish-github-pagesmetadata rewrite step on temporary copies of bothChart.yamlfiles to verify the workflow rewritesversionandappVersionto the release values.Special notes for your reviewer
.github/workflows/chart.ymlin addition to the docs so the release guide matches the tagged release behavior for both OCI charts and thegh-pageschart repository content.gh-pagesbranch content and verifying the public GitHub Pages Helm endpoint, which still depends on GitHub Pages being enabled for the repository.