As discussed in #612 (comment), the usage of GenerateAccessibilityRequirements in the following code could be improved:
https://github.com/pohly/external-provisioner/blob/f262e0f93ce2c172ac22f54978bbb9aff7f59d21/pkg/controller/controller.go#L1296-L1320
It works because the function is expected to only fail when the storage class topology is not compatible with the current node, but that is not obvious.
Options to make it more obvious:
- split out relevant code from
GenerateAccessibilityRequirements which checks the topology or
- add an error code for "not compatible" to
GenerateAccessibilityRequirements and check for that
As discussed in #612 (comment), the usage of
GenerateAccessibilityRequirementsin the following code could be improved:https://github.com/pohly/external-provisioner/blob/f262e0f93ce2c172ac22f54978bbb9aff7f59d21/pkg/controller/controller.go#L1296-L1320
It works because the function is expected to only fail when the storage class topology is not compatible with the current node, but that is not obvious.
Options to make it more obvious:
GenerateAccessibilityRequirementswhich checks the topology orGenerateAccessibilityRequirementsand check for that