refactor: use common sidecar flags functionality#1421
refactor: use common sidecar flags functionality#1421k8s-ci-robot merged 1 commit intokubernetes-csi:masterfrom
Conversation
|
Welcome @DerekFrank! |
|
Hi @DerekFrank. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
623dc69 to
bcb5fa6
Compare
|
ok-to-test |
|
/ok-to-test |
|
/retest |
40af732 to
971923c
Compare
971923c to
f0f1a30
Compare
|
@DerekFrank: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
8f6d53b to
629cc2c
Compare
629cc2c to
4d17db1
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DerekFrank, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Completes refactor found in kubernetes-csi/csi-lib-utils#202
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: