refactor: use common sidecar flags functionality#1336
refactor: use common sidecar flags functionality#1336DerekFrank wants to merge 3 commits intokubernetes-csi:masterfrom
Conversation
|
Welcome @DerekFrank! |
|
Hi @DerekFrank. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DerekFrank The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
2ec6842 to
338b17d
Compare
|
@DerekFrank: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@DerekFrank Hi Derek, This pr is crucial for our project. Please let me know if you're unable to complete it, and we can discuss how to proceed. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Closing this PR as #1355 is merged. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Continues the refactor started by kubernetes-csi/csi-lib-utils#202
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: