Makefile: skip helm push when not on a git tag#141
Open
fmuyassarov wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
Makefile: skip helm push when not on a git tag#141fmuyassarov wants to merge 1 commit intokubernetes-sigs:mainfrom
fmuyassarov wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
the
kind/failing-test
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fmuyassarov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/S
Member
Author
The release target previously always ran helm-package and helm-push, causing postsubmit CI failures on non-tag commits. Now helm steps are conditionally skipped when HELM_TAG is not set. Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>
fmuyassarov
force-pushed
the
fix/helm-packaing-semver
branch
from
740dbe1 to
cede4f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
The
releaseMakefile target previously always ranhelm-packageandhelm-push, causing postsubmit CI failures on non-tag commits. Now helm steps are conditionally skipped whenHELM_TAGis not setWhich issue(s) this PR is related to:
Fixes: #140
Special notes for your reviewer:
Does this PR introduce a user-facing change?